WWSTCERT-8045 - Aeotec Home Energy Meter Gen8 (Revert + fixes)#2791
WWSTCERT-8045 - Aeotec Home Energy Meter Gen8 (Revert + fixes)#2791KKlimczukS wants to merge 11 commits intomainfrom
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 72 files 495 suites 0s ⏱️ Results for commit 044028c. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 044028c |
greens
left a comment
There was a problem hiding this comment.
@KKlimczukS are you open to making changes to this PR beyond the updates?
greens
left a comment
There was a problem hiding this comment.
There seems to be a lot of overlap between the three sub-drivers that could be pulled up into the parent. As far as I can tell the only difference between 2-phase and 3-phase are the endpoints used for meter reports and the fingerprints. I didn't check 1-phase but assume it is similar. Also please shorten the copyright/license statement to the new format.
|
WWSTCERT-8045 - Aeotec Home Energy Meter Gen8
cleanup + fixes