Skip to content

WWSTCERT-8045 - Aeotec Home Energy Meter Gen8 (Revert + fixes)#2791

Open
KKlimczukS wants to merge 11 commits intomainfrom
Aeotec_HEM8
Open

WWSTCERT-8045 - Aeotec Home Energy Meter Gen8 (Revert + fixes)#2791
KKlimczukS wants to merge 11 commits intomainfrom
Aeotec_HEM8

Conversation

@KKlimczukS
Copy link
Contributor

WWSTCERT-8045 - Aeotec Home Energy Meter Gen8
cleanup + fixes

@github-actions
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

Test Results

   72 files    495 suites   0s ⏱️
2 707 tests 2 707 ✅ 0 💤 0 ❌
4 610 runs  4 610 ✅ 0 💤 0 ❌

Results for commit 044028c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

File Coverage
All files 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/preferences.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/aeotec-home-energy-meter-gen8/init.lua 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-electric-meter/src/aeotec-home-energy-meter-gen8/power_consumption.lua 94%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 044028c

@KKlimczukS KKlimczukS changed the title WWSTCERT-8045 - Aeotec Home Energy Meter Gen8 WWSTCERT-8045 - Aeotec Home Energy Meter Gen8 (Revert + fixes) Feb 20, 2026
@KKlimczukS KKlimczukS requested a review from greens February 20, 2026 16:35
Copy link
Contributor

@greens greens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KKlimczukS are you open to making changes to this PR beyond the updates?

Copy link
Contributor

@greens greens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a lot of overlap between the three sub-drivers that could be pulled up into the parent. As far as I can tell the only difference between 2-phase and 3-phase are the endpoints used for meter reports and the fingerprints. I didn't check 1-phase but assume it is similar. Also please shorten the copyright/license statement to the new format.

@KKlimczukS
Copy link
Contributor Author

There seems to be a lot of overlap between the three sub-drivers that could be pulled up into the parent. As far as I can tell the only difference between 2-phase and 3-phase are the endpoints used for meter reports and the fingerprints. I didn't check 1-phase but assume it is similar. Also please shorten the copyright/license statement to the new format.

@greens

  • I moved several duplicated functions to the parent,
  • supporting powerConsumptionEvents was moved to a separate file
  • The rest of the code relies on HEM8_DEVICES tables - those keep data strictly related to specific version of the device, so those need to stay in sub-sub-drivers, otherwise further refactoring might basically flatten the whole structure

@KKlimczukS KKlimczukS requested a review from greens March 13, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants